Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Now Playing" Artwork is available but isn't fetched with macOS players #117515

Open
deviantintegral opened this issue May 15, 2024 · 1 comment

Comments

@deviantintegral
Copy link
Contributor

deviantintegral commented May 15, 2024

The problem

I set up the Apple TV integration for my Mac so I could access the artwork in Home Assistant. Surprisingly, it wasn't shown. I set up pyatv directly and noticed that atvremote artwork did show the album art.

It looks like the problem may be in this line:

https://github.com/home-assistant/core/blob/dev/homeassistant/components/apple_tv/media_player.py#L358

When I run atvremote features, it shows artwork as Unknown. But, if I remove that check, the art shows up properly in home assistant.

Why I think this may be a bug in the component, and not the underlying library, is that the comment in https://github.com/postlund/pyatv/blob/e370ee1931eabaf1f1fc7fb15ecc7a9a92821c3f/pyatv/protocols/dmap/__init__.py#L76 specifically says "we don't [know] now if available". There's also a test that the feature is always unknown, so that makes me think the above conditional can never return true. I'm guessing artwork from an AppleTV works fine because it must use mrp instead of dmap, but I haven't checked.

What version of Home Assistant Core has the issue?

2024.5.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Apple TV

Link to integration documentation on our website

https://www.home-assistant.io/integrations/apple_tv/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @postlund, mind taking a look at this issue as it has been labeled with an integration (apple_tv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of apple_tv can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign apple_tv Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


apple_tv documentation
apple_tv source
(message by IssueLinks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant