You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I set up the Apple TV integration for my Mac so I could access the artwork in Home Assistant. Surprisingly, it wasn't shown. I set up pyatv directly and noticed that atvremote artwork did show the album art.
When I run atvremote features, it shows artwork as Unknown. But, if I remove that check, the art shows up properly in home assistant.
Why I think this may be a bug in the component, and not the underlying library, is that the comment in https://github.com/postlund/pyatv/blob/e370ee1931eabaf1f1fc7fb15ecc7a9a92821c3f/pyatv/protocols/dmap/__init__.py#L76 specifically says "we don't [know] now if available". There's also a test that the feature is always unknown, so that makes me think the above conditional can never return true. I'm guessing artwork from an AppleTV works fine because it must use mrp instead of dmap, but I haven't checked.
What version of Home Assistant Core has the issue?
2024.5.3
What was the last working version of Home Assistant Core?
Hey there @postlund, mind taking a look at this issue as it has been labeled with an integration (apple_tv) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of apple_tv can trigger bot actions by commenting:
@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign apple_tv Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.
The problem
I set up the Apple TV integration for my Mac so I could access the artwork in Home Assistant. Surprisingly, it wasn't shown. I set up pyatv directly and noticed that
atvremote artwork
did show the album art.It looks like the problem may be in this line:
https://github.com/home-assistant/core/blob/dev/homeassistant/components/apple_tv/media_player.py#L358
When I run
atvremote features
, it shows artwork asUnknown
. But, if I remove that check, the art shows up properly in home assistant.Why I think this may be a bug in the component, and not the underlying library, is that the comment in https://github.com/postlund/pyatv/blob/e370ee1931eabaf1f1fc7fb15ecc7a9a92821c3f/pyatv/protocols/dmap/__init__.py#L76 specifically says "we don't [know] now if available". There's also a test that the feature is always unknown, so that makes me think the above conditional can never return true. I'm guessing artwork from an AppleTV works fine because it must use mrp instead of dmap, but I haven't checked.
What version of Home Assistant Core has the issue?
2024.5.3
What was the last working version of Home Assistant Core?
No response
What type of installation are you running?
Home Assistant OS
Integration causing the issue
Apple TV
Link to integration documentation on our website
https://www.home-assistant.io/integrations/apple_tv/
Diagnostics information
No response
Example YAML snippet
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: