Fix bug when perspective has not been rendered #6847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6847 +/- ##
==========================================
- Coverage 81.51% 81.50% -0.02%
==========================================
Files 318 318
Lines 46709 46709
==========================================
- Hits 38076 38068 -8
- Misses 8633 8641 +8 ☔ View full report in Codecov by Sentry. |
philippjfr
approved these changes
May 17, 2024
philippjfr
pushed a commit
that referenced
this pull request
May 17, 2024
* fix bug when perspective has not been rendered * add space before brace
philippjfr
pushed a commit
that referenced
this pull request
May 21, 2024
* fix bug when perspective has not been rendered * add space before brace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #6846
I've tested this manually on my complex application and it solves the problem.