Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mistakes in the documentation #88

Open
GoldElysium opened this issue Feb 9, 2021 · 1 comment · May be fixed by #89 or #90
Open

Mistakes in the documentation #88

GoldElysium opened this issue Feb 9, 2021 · 1 comment · May be fixed by #89 or #90
Assignees
@Chooks22

Comments

@GoldElysium
Copy link

  • Video object in API has a status property, not seen in docs response schema.
  • Channel has: views, subscribers and videos property, not seen in docs either
  • /comments/search response schema shows that it has a data property, while it is comments, better would be to change it to videos as this is what it actually returns.

Other questions:

  • From what I can see, nothing from Bilibili is in the DB yet? Might be useful to note that in the description.
  • What is the photo property supposed to in channel? If there's no use for it(I haven't seen it populated) might be an idea to put the YT profile picture there?
  • Thumbnail property also seems to be always empty? I suppose that needs to be a video thumbnail, the url seems to be https://i.ytimg.com/vi/ID/maxresdefault.jpg and https://i.ytimg.com/vi/ID/maxresdefault_live.jpg. The second URL seems to only work with live livestreams, but the first url also works. Not sure what the difference is.
@Chooks22
Copy link
Contributor

Hey, sorry for the late response

• Basically Bilibili crawlers aren't implemented yet, not exactly sure what the plan for that is but the db schema is already defined, there's just no Bilibili video data on it.
• If you're referring to Video.channel.photo, it is populated though. It's the thumbnail url for the channel.
• Video.thumbnail property was reserved for Bilibili video thumbnails, since you can just build the thumbnail url from the video id.

As for the docs, I'll update it in a bit

@Chooks22 Chooks22 self-assigned this Feb 12, 2021
@Chooks22 Chooks22 linked a pull request Feb 12, 2021 that will close this issue
Open
@Chooks22 Chooks22 linked a pull request Feb 12, 2021 that will close this issue
Update swagger docs #89
Open
@GoldElysium GoldElysium linked a pull request Feb 12, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chooks22 Chooks22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update swagger docs Chooks22/holoapi
Change comments property to videos GoldElysium/holoapi
2 participants
@GoldElysium @Chooks22