Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalOtsuThreshold should return a np.ndarray #404

Open
alessiamarcolini opened this issue May 5, 2022 · 0 comments
Open

LocalOtsuThreshold should return a np.ndarray #404

alessiamarcolini opened this issue May 5, 2022 · 0 comments
Assignees
@ernestoarbitrio
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@alessiamarcolini
Copy link
Collaborator

Describe the bug
LocalOtsuThreshold should return a binary mask as np.ndarray, like its "sibling" OtsuThreshold

  1. We should not apply np_to_pil before returning, but threshold_to_mask (like OtsuThreshold)
  2. The docstrings of LocalOtsuThreshold and local_otsu_threshold are different, while they should be the same.
  3. Type hints need to be fixed as well to reflect the new changes
@alessiamarcolini alessiamarcolini added bug Something isn't working good first issue Good for newcomers labels May 5, 2022
@ernestoarbitrio ernestoarbitrio self-assigned this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ernestoarbitrio ernestoarbitrio

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ernestoarbitrio @alessiamarcolini