Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Tiler interface #378

Open
Christopher22 opened this issue Jan 26, 2022 · 0 comments
Open

Extend Tiler interface #378

Christopher22 opened this issue Jan 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Christopher22
Copy link
Contributor

Currently, the different Tiler support the check_tissue as a boolean parameter. An additional configuration like tissue_percent is given as another parameter. This makes extensions as in the case of issue #354 complicated.

I propose to accept a callable in check_tissue instead. We could then design an (abstract) class TileChecker with a subclass MinTissuePercent or something similar. We then gain additional flexibility and support other workflows.

I would be happy to contribute a pull request. However, is such a breaking change acceptable?
@Christopher22 Christopher22 added the enhancement New feature or request label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Christopher22