Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to support python 3.8 under windows #285

Closed
wants to merge 27 commits into from
Closed

try to support python 3.8 under windows #285

wants to merge 27 commits into from

Conversation

alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Jul 18, 2021 •
edited

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@codecov
Copy link

codecov bot commented Jul 18, 2021 •
edited

Codecov Report

Merging #285 (27cc9e1) into master (e5e2884) will decrease coverage by 0.64%.
The diff coverage is 20.00%.

❗ Current head 27cc9e1 differs from pull request most recent head ab8cd28. Consider uploading reports for the commit ab8cd28 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            master     #285      +/-   ##
===========================================
- Coverage   100.00%   99.35%   -0.65%     
===========================================
  Files           17       17              
  Lines         1307     1245      -62     
  Branches       128      119       -9     
===========================================
- Hits          1307     1237      -70     
- Misses           0        6       +6     
- Partials         0        2       +2
Impacted Files Coverage Δ
src/histolab/data/__init__.py 94.93% <20.00%> (ø)
src/histolab/slide.py 97.80% <20.00%> (ø)
histolab/util.py
histolab/filters/compositions.py
histolab/scorer.py
histolab/filters/image_filters_functional.py
histolab/masks.py
histolab/filters/morphological_filters.py
...stolab/filters/morphological_filters_functional.py
histolab/slide.py
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e2884...ab8cd28. Read the comment docs.

@alessiamarcolini alessiamarcolini deleted the branch master August 17, 2023 09:04
@alessiamarcolini alessiamarcolini mentioned this pull request Aug 17, 2023
Closed
11 tasks
@ernestoarbitrio ernestoarbitrio deleted the py38-windows branch February 24, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
idle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Python 3.8 under Windows
2 participants
@alessiamarcolini @ernestoarbitrio