Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish binaries #256

Open
mkroening opened this issue Dec 16, 2021 · 4 comments · May be fixed by #705
Open

Publish binaries #256

mkroening opened this issue Dec 16, 2021 · 4 comments · May be fixed by #705

Comments

@mkroening
Copy link
Member

Not having to build uhyve in our other project's CI should speed them up.

@n0toose
Copy link

n0toose commented Jun 5, 2024

Is this issue still a problem? (I presume yes.)

If so, I presume that #271 is a dependency and should be done first?

@n0toose
Copy link

n0toose commented Jun 5, 2024

There are a few things that could be done here, which are in- and out-of-scope?

  • Build debug binaries on each push/commit, which may be useful for debugging if an integration test fails.
  • Build release binaries using GitHub Actions and publish them on the creation of a new tag.

@mkroening
Copy link
Member Author

If so, I presume that #271 is a dependency and should be done first?

I would not say so. (But I also don't think we should containerize the CI. That's not a good fit for GitHub Actions in my opinion.)

  • Build debug binaries on each push/commit, which may be useful for debugging if an integration test fails.

  • Build release binaries using GitHub Actions and publish them on the creation of a new tag.

I think we don't win much from nightly builds, so I'd say release binaries on tags would be good. I have done something similar for a private project: https://github.com/mkroening/edu-sync/blob/main/.github/workflows/release.yml

@mkroening
Copy link
Member Author

Is this issue still a problem? (I presume yes.)

Now that I think about it: Not really. We only install Uhyve on our private KVM runners, which skip installation if already present, so there is not much to win here.

So this issue would be nice to have, but we don't win much either.

n0toose added a commit to n0toose/uhyve that referenced this issue Jun 10, 2024
Because of time constraints and because the workflow itself
may need some additional work to support multiple operating systems
without making individual releases for every target architecture
and operating system, builds are only generated for Linux (amd64).

New releases are marked as "Drafts" by default, so as to allow
maintainers to edit the text before publication.

Fixes hermit-os#256
@n0toose n0toose linked a pull request Jun 10, 2024 that will close this issue
n0toose added a commit to n0toose/uhyve that referenced this issue Jun 10, 2024
Because of time constraints and because the workflow itself
may need some additional work to support multiple operating systems
without making individual releases for every target architecture
and operating system, builds are only generated for Linux (amd64).

New releases are marked as "Drafts" by default, so as to allow
maintainers to edit the text before publication.

Fixes hermit-os#256
n0toose added a commit to n0toose/uhyve that referenced this issue Jun 10, 2024
Because of time constraints and because the workflow itself
may need some additional work to support multiple operating systems
without making individual releases for every target architecture
and operating system, builds are only generated for Linux (amd64).

New releases are marked as "Drafts" by default, so as to allow
maintainers to edit the text before publication.

Fixes hermit-os#256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants