-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure: Drop generated files #283
base: master
Are you sure you want to change the base?
Conversation
@bgamari makes sense, but CI fails unfortunately. |
@bgamari would not it suffice for GHC development purposes to remove |
@bgamari marking as draft until CI issue is resolved. |
Any news here? |
I have rebased this and reworked the patch to only drop |
@bgamari @hasufell any ideas about CI failure on CentOS?
|
Very strange; unfortunately I have no idea. I have tried to reproduce this in a |
OK, CentOS and i386 failures are unrelated (see #300). @bgamari this leaves us blocked on ARM jobs like https://github.com/haskell/unix/actions/runs/6395893930/job/17360539330?pr=283#step:7:137. Any ideas how to fix them?
|
Oh dear, yes. The problem is that |
@bgamari that's fine as long as you can fix the CI job. It seems to run Lines 127 to 131 in d63e6b4
|
This is a generated file which should not be present in the repository. Fixes ghc#19574.
As much as I can figure out, the issue plagues runners with # Make sure we can run config.sub.
$SHELL "${ac_aux_dir}config.sub" sun4 >/dev/null 2>&1 ||
as_fn_error $? "cannot run $SHELL ${ac_aux_dir}config.sub" "$LINENO" 5 I don't know what is the blessed way to resolve it, except migrating to ac_cv_build=`$SHELL "${ac_aux_dir}config.sub" $ac_build_alias` ||
as_fn_error $? "$SHELL ${ac_aux_dir}config.sub $ac_build_alias failed" "$LINENO" 5 |
This is a generated file which should not be present in the repository.
Fixes ghc#19574.
Fixes #257 .