Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stimes implementations #288

Open
sjakobi opened this issue Jun 12, 2020 · 3 comments · May be fixed by #580
Open

stimes implementations #288

sjakobi opened this issue Jun 12, 2020 · 3 comments · May be fixed by #580
Labels
feature request internal No API-level changes

Comments

@sjakobi
Copy link
Member

sjakobi commented Jun 12, 2020

I noticed that the Semigroup instances don't explicitly define stimes. I suspect its possible to improve on the default definitions.
@Boarders
Copy link

Boarders commented Mar 6, 2021

I think we should be able to use a suitable variant of replicate (that accepts an integral argument) to improve the situation. We could also provide an implementation for sconcat that uses the specialised concat function as the default implementation probably allocates way more than needed.

@Lysxia Lysxia added feature request internal No API-level changes labels Mar 7, 2021
@kindaro
Copy link
Contributor

kindaro commented Feb 22, 2024

I shall look into it. At least I can draft some code that type checks and then we shall see if there is improvement in bench marks.

@kindaro kindaro linked a pull request Apr 12, 2024 that will close this issue
Draft
@kindaro
Copy link
Contributor

kindaro commented Apr 12, 2024

And there is improvement in bench marks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request internal No API-level changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: sconcat and stimes. kindaro/text
4 participants
@Lysxia @kindaro @sjakobi @Boarders