Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why is IReader using String instead of Text? #432

Open
marcosh opened this issue May 13, 2022 · 1 comment
Open

why is IReader using String instead of Text? #432

marcosh opened this issue May 13, 2022 · 1 comment
Labels
question Requires more investigation

Comments

@marcosh
Copy link

marcosh commented May 13, 2022

IReader is defined as

type IReader t a = t -> Either String (a, t)

What is the reason why it is using String instead of Text for the failure case?

@Lysxia
Copy link
Contributor

Lysxia commented May 15, 2022

I would guess historical reasons, like that fail expects a String, or that libraries before text probably used String already for error messages.

There may be value in making Text really replace uses of String, but that transition seems like it should be decided and coordinated on a global level, starting with a strong enough motivation.

@Lysxia Lysxia added the question Requires more investigation label May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Requires more investigation
Projects
None yet
Development

No branches or pull requests

2 participants