Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear migration with respect to removal of Language.LSP.Server.setupLogger #441

Open
sjakobi opened this issue Jun 20, 2022 · 1 comment

Comments

@sjakobi
Copy link
Member

sjakobi commented Jun 20, 2022

We were using this action in dhall-lsp-server

-- | The main entry point for the LSP server.
run :: Maybe FilePath -> IO ()
run mlog = do
  setupLogger mlog
  ...

What's the correct response to the removal? The changelog doesn't mention this.

@michaelpj
Copy link
Collaborator

The logging has moved to co-log-core, we don't use hslogger at all any more. So you just delete it and pass LogActions where the compiler tells you to instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants