Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for lsp-types-1.5 doesn't mention switch to text-rope #440

Open
sjakobi opened this issue Jun 20, 2022 · 1 comment
Open

Changelog for lsp-types-1.5 doesn't mention switch to text-rope #440

sjakobi opened this issue Jun 20, 2022 · 1 comment

Comments

@sjakobi
Copy link
Member

sjakobi commented Jun 20, 2022

dhall-lsp-server is showing a build failure related to this:

src/Dhall/LSP/Handlers.hs:94:60: error:
    • Couldn't match expected type ‘Rope.Rope’
                  with actual type ‘text-rope-0.2:Data.Text.Utf16.Rope.Rope’
      NB: ‘text-rope-0.2:Data.Text.Utf16.Rope.Rope’
            is defined in ‘Data.Text.Utf16.Rope’ in package ‘text-rope-0.2’
          ‘Rope.Rope’
            is defined in ‘Data.Rope.UTF16.Internal’
                in package ‘rope-utf16-splay-0.3.2.0’
    • In the first argument of ‘Rope.toText’, namely ‘rope’
      In the first argument of ‘return’, namely ‘(Rope.toText rope)’
      In the expression: return (Rope.toText rope)
   |
94 |     Just (LSP.VirtualFile _ _ rope) -> return (Rope.toText rope)
   |                                                            ^^^^
@michaelpj
Copy link
Collaborator

We should probably not expose the constructors of VirtualFile anyway. Use virtualFileText.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants