Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buggy dirty mechanism in hls-graph #4237

Closed
soulomoon opened this issue May 17, 2024 · 1 comment · Fixed by #4238
Closed

buggy dirty mechanism in hls-graph #4237

soulomoon opened this issue May 17, 2024 · 1 comment · Fixed by #4238
Assignees
Labels

Comments

@soulomoon
Copy link
Collaborator

soulomoon commented May 17, 2024

Following situation could trigger a bug

rule runs the first time
rule runs with dep changed, recomputed but result won't change
rule runs with itself marked dirty, the rule did not rerun
rule runs with itself marked dirty, the rule reruns which it should not

Also comment should added to specify how the hls-graph dirty mechanism is working.

@soulomoon soulomoon self-assigned this May 17, 2024
@soulomoon soulomoon linked a pull request May 17, 2024 that will close this issue
@soulomoon soulomoon changed the title Clarify the dirty mechanism of hls-graph Dirty mechanism have a problem in hls-graph May 17, 2024
@soulomoon
Copy link
Collaborator Author

soulomoon commented May 17, 2024

resultBuilt might updated to an older value, which make a rule result that should be clean back to dirty. It should trigger unwanted recomputation

@soulomoon soulomoon changed the title Dirty mechanism have a problem in hls-graph buggy dirty mechanism in hls-graph May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant