You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
expectFail interprets a test failure for any reason as a success. But since we don't check why exactly the test is failing, we lose valuable information.
Thus, many of the tests that use expectFail are likely not really testing what they are supposed to be.
In my opinion, we should replace all occurrences of expectFail with an assertion that shows what is failing precisely, or delete/ignore the respective test case.
The text was updated successfully, but these errors were encountered:
expectFail
interprets a test failure for any reason as a success. But since we don't check why exactly the test is failing, we lose valuable information.Thus, many of the tests that use
expectFail
are likely not really testing what they are supposed to be.In my opinion, we should replace all occurrences of
expectFail
with an assertion that shows what is failing precisely, or delete/ignore the respective test case.The text was updated successfully, but these errors were encountered: