Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid expectFail in the test suite #4130

Open
fendor opened this issue Mar 10, 2024 · 0 comments
Open

Avoid expectFail in the test suite #4130

fendor opened this issue Mar 10, 2024 · 0 comments
Labels
type: enhancement New feature or request

Comments

@fendor
Copy link
Collaborator

fendor commented Mar 10, 2024

expectFail interprets a test failure for any reason as a success. But since we don't check why exactly the test is failing, we lose valuable information.
Thus, many of the tests that use expectFail are likely not really testing what they are supposed to be.

In my opinion, we should replace all occurrences of expectFail with an assertion that shows what is failing precisely, or delete/ignore the respective test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant