Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure finalCheckPackage, moving it earlier in the cabal-install pipeline #9995

Open
sheaf opened this issue May 10, 2024 · 0 comments
Open

Comments

@sheaf
Copy link
Collaborator

sheaf commented May 10, 2024

finalCheckPackage (and thus checkPackageProblems) currently performs several different kinds of check on the package:

  • checks on the level of the GenericPackageDescription, such as the checks in checkGenericPackageDescription
  • checks on the PackageDescription that may have had hooks applied (either via the old UserHooks, or new SetupHooks).

This ticket tracks splitting up this logic, so that all the checks on the level of the GenericPackageDescription are done as early as possible within cabal-install (as early as it makes sense to do them; perhaps in project planning). The remaining checks would only need to check information modified by the hooks, but would thus need to be done later, after hooks have been applied (in the case of SetupHooks, after we have configured the package and its components).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant