Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The first column of synthetic data in the first example should be set to 0 instead of 1? #116

Open
alaneuler opened this issue Oct 11, 2023 · 0 comments
Open

The first column of synthetic data in the first example should be set to 0 instead of 1? #116

alaneuler opened this issue Oct 11, 2023 · 0 comments

Comments

@alaneuler
Copy link

alaneuler commented Oct 11, 2023 •
edited

Skimmed through old version of "annotated-transformer" the start_symbol is 1:
image
but changed to 0 afterwards. Should the code in method data_gen also be changed to 0 for consistence?
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alaneuler