-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow-dup-ip
is ignored if server has resolvers
and backend has default-server
#2559
Labels
2.0
This issue affects the HAProxy 2.0 stable branch.
2.2
This issue affects the HAProxy 2.2 stable branch.
status: fixed
This issue is a now-fixed bug.
type: bug
This issue describes a bug.
Comments
sigint2
added
status: needs-triage
This issue needs to be triaged.
type: bug
This issue describes a bug.
labels
May 6, 2024
Indeed, it seems you're right. There is no reason to reset resolve options when a |
capflam
added
dev
This issue affects the HAProxy development branch.
status: reviewed
This issue was reviewed. A fix is required.
2.0
This issue affects the HAProxy 2.0 stable branch.
2.2
This issue affects the HAProxy 2.2 stable branch.
2.4
This issue affects the HAProxy 2.4 stable branch.
2.6
This issue affects the HAProxy 2.6 stable branch.
2.8
This issue affects the HAProxy 2.8 stable branch.
2.9
This issue affects the HAProxy 2.9 stable branch.
and removed
status: needs-triage
This issue needs to be triaged.
labels
May 7, 2024
haproxy-mirror
pushed a commit
that referenced
this issue
May 24, 2024
…er line When a new "default-server" line is parsed, some resolver options are reset. Thus previously defined default options cannot be inherited. There is no reason to do so. First because other server options are inherited. And then because not all resolver options are reset. It is not consistent. This patch should fix issue #2559. It should be backported to all stable versions.
Fixed now, thanks ! |
capflam
added
status: fixed
This issue is a now-fixed bug.
and removed
dev
This issue affects the HAProxy development branch.
status: reviewed
This issue was reviewed. A fix is required.
labels
May 24, 2024
FireBurn
pushed a commit
to FireBurn/haproxy
that referenced
this issue
Jun 7, 2024
…er line When a new "default-server" line is parsed, some resolver options are reset. Thus previously defined default options cannot be inherited. There is no reason to do so. First because other server options are inherited. And then because not all resolver options are reset. It is not consistent. This patch should fix issue haproxy#2559. It should be backported to all stable versions. (cherry picked from commit 0d7c1bc) Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com>
FireBurn
pushed a commit
to FireBurn/haproxy
that referenced
this issue
Jun 7, 2024
…er line When a new "default-server" line is parsed, some resolver options are reset. Thus previously defined default options cannot be inherited. There is no reason to do so. First because other server options are inherited. And then because not all resolver options are reset. It is not consistent. This patch should fix issue haproxy#2559. It should be backported to all stable versions. (cherry picked from commit 0d7c1bc) Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com> (cherry picked from commit 7600de7) Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com>
FireBurn
pushed a commit
to FireBurn/haproxy
that referenced
this issue
Jun 8, 2024
…er line When a new "default-server" line is parsed, some resolver options are reset. Thus previously defined default options cannot be inherited. There is no reason to do so. First because other server options are inherited. And then because not all resolver options are reset. It is not consistent. This patch should fix issue haproxy#2559. It should be backported to all stable versions. (cherry picked from commit 0d7c1bc) Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com> (cherry picked from commit 7600de7) Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com> (cherry picked from commit bff1fef) Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com>
FireBurn
pushed a commit
to FireBurn/haproxy
that referenced
this issue
Jun 11, 2024
…er line When a new "default-server" line is parsed, some resolver options are reset. Thus previously defined default options cannot be inherited. There is no reason to do so. First because other server options are inherited. And then because not all resolver options are reset. It is not consistent. This patch should fix issue haproxy#2559. It should be backported to all stable versions. (cherry picked from commit 0d7c1bc) Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com> (cherry picked from commit 7600de7) Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com> (cherry picked from commit bff1fef) Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com> (cherry picked from commit f158e83) Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com>
capflam
removed
2.4
This issue affects the HAProxy 2.4 stable branch.
2.6
This issue affects the HAProxy 2.6 stable branch.
2.8
This issue affects the HAProxy 2.8 stable branch.
labels
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.0
This issue affects the HAProxy 2.0 stable branch.
2.2
This issue affects the HAProxy 2.2 stable branch.
status: fixed
This issue is a now-fixed bug.
type: bug
This issue describes a bug.
Detailed Description of the Problem
Hi -- I noticed that
allow-dup-ip
is ignored when:resolvers
associated with it ( either explicitly, or via a default ), ANDdefault-server
line in it.Expected Behavior
That the global
default-server resolve-opts
are not reset by adefault-server
in a backend.Steps to Reproduce the Behavior
The following config should illustrate the behavior:
default-server backup
is applied to all serversdefaults
weight42
is applied to all servers.defaults
fieldresolve-opts allow-dup-ip
is not applied ( stats page shows serverapp2
in maintenance mode )the weight of the servers is overridden with
42
Do you have any idea what may have caused this?
In
src/server.c
the resolve opts seem to get reset to hard-coded values when the above conditions are met, the other option that is reset isresolve-prefer
.Do you have an idea how to solve the issue?
No response
What is your configuration?
Output of
haproxy -vv
Last Outputs and Backtraces
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: