Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve communication between purity and assign #83

Open
cmorganl opened this issue Apr 10, 2021 · 0 comments
Open

Improve communication between purity and assign #83

cmorganl opened this issue Apr 10, 2021 · 0 comments
Assignees
Labels
enhancement Highlight something that could be improved. Please be specific, TreeSAPP isn't perfect.

Comments

@cmorganl
Copy link
Collaborator

treesapp purity calls treesapp assign to classify the reference sequences. The warning and error messages are verbose in each, but if there is an error in treesapp assign the exact cause of the error, and whether it truly is a bug or other issue can get muddled.

For example, when there are no alignments found in the reference database, a warning is correctly issued followed by three errors:

WARNING:
No alignments found! TreeSAPP is exiting now.
ERROR - commands, line 1176:
TreeSAPP failed.
ERROR - commands, line 1188:
marker_contig_map.tsv is missing from output directory 'intermediates/assign/final_outputs'
Please remove this directory and re-run.

treesapp assign needs to return an error code that can be properly interpreted by the wrapping subcommand.

@cmorganl cmorganl added the enhancement Highlight something that could be improved. Please be specific, TreeSAPP isn't perfect. label Apr 10, 2021
@cmorganl cmorganl self-assigned this Apr 10, 2021
@cmorganl cmorganl added this to To do in v0.12.0 Apr 12, 2021
@cmorganl cmorganl removed this from To do in v0.12.0 Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Highlight something that could be improved. Please be specific, TreeSAPP isn't perfect.
Projects
None yet
Development

No branches or pull requests

1 participant