Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate h2o-3 package on R 4.4 and add test image to jenkins #16177

Open
tomasfryda opened this issue Apr 25, 2024 · 2 comments
Open

Validate h2o-3 package on R 4.4 and add test image to jenkins #16177

tomasfryda opened this issue Apr 25, 2024 · 2 comments
Assignees
@tomasfryda
Milestone
3.46.0.3

Comments

@tomasfryda
Copy link
Contributor

New R version was released, so we should check if the current release is releasable to CRAN and if not fix the issues so that we don't have to fix the package after the release to be able to put it on CRAN.

Change log:
https://stat.ethz.ch/pipermail/r-announce/2024/000701.html

It would be also nice to run at least some tests to find out that the changes don't break some core functionality (and ideally test this version on jenkins).
@tomasfryda tomasfryda self-assigned this Apr 25, 2024
@wendycwong
Copy link
Contributor

This issue is becoming more urgent now as our customer is asking for it. We should get this test on Jenkins going.

@wendycwong
Copy link
Contributor

Once this is done, we can try to submit our package to CRAN.

@wendycwong wendycwong self-assigned this May 30, 2024
@tomasfryda tomasfryda changed the title Validate h2o-3 package on R 4.4 Validate h2o-3 package on R 4.4 and add test image to jenkins May 31, 2024
@tomasfryda tomasfryda mentioned this issue May 31, 2024
Merged
@wendycwong wendycwong removed their assignment Jun 3, 2024
@tomasfryda tomasfryda added this to the 3.46.0.3 milestone Jun 4, 2024
tomasfryda added a commit that referenced this issue Jun 7, 2024
@tomasfryda
GH-16177: Validate h2o 3 package on r 4 4 and add test image to jenki…
18341e3 
…ns (#16291)

* Add update dependencies for R 4.4.0

* Enable R 4.4.0 image

* Fix runit_GBM_weight_gamma.R

* Deal with .checkFieldsInMethod warning

* Add html tidy to the R image for CRAN check

* Fix runit_coxph_concordance.R test

* Fix runit_coxph_concordance_heart.R test

* Fix runit_coxph_predict.R

* Fix runit_pubdev_8945_coxph_all_interactions_mojo.R

* Fix runit_GBM_ecology.R

* Install uplift package even if it was archived

* Fix runit_GLM_libR_airlines.R

* Fix runit_GLM_offset.R

* Fix runit_PUBDEV_6037_fractionalbinomial_mojo.R

* Fix runit_PUBDEV_8638_bodyfat_RID_Binomial_compareR_test.R

* Fix runit_glrm_PUBDEV_3788_loss_by_col_err.R

* Fix runit_isofor_accuracy.R

* Fix runit_PUBDEV_8235_modelselection_gaussian_validation.R

* Fix runit_OLD_1079_airlines.R

* Fix runit_pubdev_6817_noK_PCA.R

* Fix runit_pca_5_golden.R

* Fix javapredict

* Fix runit_head_tail.R

* Fix runit_relevel.R

* Fix runit_import_upload_singlequoted.R

* Fix runit_ifelse.R

* Fix runit_h2oconfig.R and .parse.h2oconfig in config.R

* Fix runit_as.h2o_sparse.R

* Fix runit_pubdev_8218.R

* Fix runit_PUBDEV_7362_merge_duplicate_others.R

* Fix runit_pubdev_1654.R

* Fix runit_pubdev_1398.R

* Fix runit_pubdev_1383.R

* Fix runit_hexdev_29_categorical_continuous.R

* Fix runit_GLM_offset.R for R 3.5

* Add DT to R 4.4 image

* Do not set options(stringsAsFactors=TRUE) in the tests

* Fix runit_as.h2o_sparse.R

* Add new cran messages to validate_r_cmf_check_output.py

* More changes to the validate_r_cmd_check_output.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasfryda tomasfryda

Labels
None yet
Projects
None yet
Milestone
3.46.0.3
Development

No branches or pull requests
2 participants
@wendycwong @tomasfryda