Build the site when something is pushed to main, or on PRs #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes nothing in the output except for how it is produced, and ideally paves the way to more simply producing just the output we need for the website.
There is room for improvement here, this is meant to be a first draft before we start merging other cleanup.
|
(wrong issue commented on) |
|
Build summary, with downloadable generated JS https://github.com/niloc132/gwt-site-webapp/actions/runs/4338262581 (requires #11) |
tbroyer
reviewed
Mar 5, 2023
|
|
||
| <properties> | ||
| <maven.build.timestamp.format>yyyy-MM-dd</maven.build.timestamp.format> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
|
|
||
| <gwt.version>2.7.0</gwt.version> | ||
| <gwtquery.version>1.4.2</gwtquery.version> | ||
| <gwt.version>2.9.0</gwt.version> |
| @@ -17,36 +16,24 @@ | |||
| - To **build** and check the app, run | |||
|
|
|||
| $ cd [...]/gwt-site-webapp | |||
| $ mvn package | |||
| $ mvn verify | |||
There was a problem hiding this comment.
Shouldn't the full-site profile be mentioned somewhere in the README?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is room for improvement here, this is meant to be a first draft
before we start merging other cleanup, to validate those merges.
Fixes #7