Fix extra - when setting title for homepage
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnehlmeier
reviewed
Apr 24, 2022
|
|
||
| $("#nav a.active").removeClass("active"); | ||
| $("#nav a[href='" + mainNavigationHref + "']").addClass("active"); | ||
| $("#submenu .active").not(liParents).removeClass("active"); | ||
| liParents.add(selectedItem).not(selectedItem.parent()).addClass("active"); | ||
|
|
||
| // Change the page title for easy bookmarking | ||
| $("title").text("[GWT] " + subMenuItem.children("a").text() + " - " + selectedItem.text()); | ||
| if (section.isEmpty()) { | ||
| $("title").text("GWT Project Homepage"); |
There was a problem hiding this comment.
I would probably remove the word "Homepage".
Currently there are
- gwtproject.org
- gwtproject.org/overview.html
which do not have a submenu. So both would show "GWT Project Homepage" even though only 1. should.
In order to fix the overview.html page and being able to set a title for it, the code would also need to check GQuery selectedItem = $("#nav a[href='" + path + "']") because the current path isn't found in a #submenu (see line 128).
jnehlmeier
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.