Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gwt-core dependency for GWT.isProdMode() #7

Open
niloc132 opened this issue Jul 16, 2020 · 2 comments
Open

Add gwt-core dependency for GWT.isProdMode() #7

niloc132 opened this issue Jul 16, 2020 · 2 comments
Assignees
@niloc132
Milestone
1.0.0-RC1

Comments

@niloc132
Copy link
Contributor

This check lets us add some checks in dev mode, instead of reading the property, since that would conflict with gwt-core in a project that uses both.
@niloc132 niloc132 added this to the 1.0.0-RC1 milestone Jul 31, 2020
@FrankHossfeld
Copy link
Member

Is only needed inside the GWT test module. I think, we can close the issue.

@niloc132
Copy link
Contributor Author

niloc132 commented Oct 5, 2020

Probably should be fixed though, in case a later test ends up depending on gwt-core, or some later feature depends on gwt-core.

@niloc132 niloc132 self-assigned this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloc132 niloc132

Labels
None yet
Projects
None yet
Milestone
1.0.0-RC1
Development

No branches or pull requests
2 participants
@niloc132 @FrankHossfeld