Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing default for configuration properties #30

Open
zbynek opened this issue Mar 15, 2023 · 0 comments · May be fixed by #31
Open

Missing default for configuration properties #30

zbynek opened this issue Mar 15, 2023 · 0 comments · May be fixed by #31

Comments

@zbynek
Copy link

zbynek commented Mar 15, 2023

org.gwtproject.safecss.ForceCheckValidStyles is defined but never set which causes a NPE with GWT2 SuperDevMode; also it's never actually queried
com.google.gwt.safehtml.ForceCheckValidUri, com.google.gwt.safehtml.ForceCheckCompleteHtml are queried but never defined, which is technically OK, but not very transparent.

As a followup to gwtproject/gwt#9806 it would be nice to make sure all 3 properties are defined with "false" as a default and compared to "true" instead of null.

(I'll try to create a PR for this in the next few weeks)
@zbynek zbynek linked a pull request Mar 17, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make configuration properties explicit zbynek/gwt-safehtml
1 participant
@zbynek