Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[akka-http] form-urlencoded requestBody with format:binary generates uncompilable code #1208

Open
blast-hardcheese opened this issue Aug 28, 2021 · 0 comments
Open

[akka-http] form-urlencoded requestBody with format:binary generates uncompilable code #1208

blast-hardcheese opened this issue Aug 28, 2021 · 0 comments
Labels
bug Unexpected behaviour for functionality that either was intended to work, or has worked in the past good first issue Does not require deep knowledge of the codebase and is easily testable help wanted Easy to moderately difficult issues that don't require deep knowledge or architectural thought scala Broadly concerning Scala code generation or the generated Scala code scala-akka-http Pertains to guardrail-scala-akka-http

Comments

@blast-hardcheese
Copy link
Member

Presumably in the case of both UrlencodedFormData and MultipartFormData, optional format: binary fields should be excluded from the UrlencodedFormData path parameter parsing, emitting a static None so it's compatible with the other Unmarshaller types.

In the case of a required format: binary, we should just emit a user error and fail to generate bad code.
@blast-hardcheese blast-hardcheese added bug Unexpected behaviour for functionality that either was intended to work, or has worked in the past help wanted Easy to moderately difficult issues that don't require deep knowledge or architectural thought scala-akka-http Pertains to guardrail-scala-akka-http scala Broadly concerning Scala code generation or the generated Scala code good first issue Does not require deep knowledge of the codebase and is easily testable labels Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected behaviour for functionality that either was intended to work, or has worked in the past good first issue Does not require deep knowledge of the codebase and is easily testable help wanted Easy to moderately difficult issues that don't require deep knowledge or architectural thought scala Broadly concerning Scala code generation or the generated Scala code scala-akka-http Pertains to guardrail-scala-akka-http
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blast-hardcheese