Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsk autoscaler not working properly with Terraform Provider #236

Open
FloSchick opened this issue Jun 27, 2023 · 1 comment
Open

gsk autoscaler not working properly with Terraform Provider #236

FloSchick opened this issue Jun 27, 2023 · 1 comment

Comments

@FloSchick
Copy link

FloSchick commented Jun 27, 2023

Thanks for adding autoscaling capabilities to gsk, however the current implementation is not optimal when using it with the terraform provider. After successful upscaling, the tf-provider wants to delete that node an the next apply run.

The only viable solution to this is adding ignore_changes to the cluster:

lifecycle {
    ignore_changes = [ node_pool.0.node_count]
  }

This is also not optimal as you lose the ability to manually increase node size with terraform.
Are there any plans to integrate the autoscaling feature into the gsk platform and adding it to the terraform provider as variables of the cluster, as most providers implement it like that?

@nvthongswansea
Copy link
Contributor

@FloSchick thank you for reporting this issue. We will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants