Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between VirtualMachine.getProviderVolumeIds and getVolumes #159

Open
cafed00d opened this issue Apr 21, 2014 · 0 comments
Open

Comments

@cafed00d
Copy link

When I submitted the patch for providerVolumeIds, the whole point was to fill in the data with information that was already provided by the cloud provider. Yet I see that in 2014.03 that that getProviderVolumeIds required a provider as a parameter and makes a separate call to get the volume ids! Why?
Looking at the AWS code, in EC2Instance, lines 2038 through 2080, I see that the code is scanning the results returned from AWS and building Volume entries, and on line 2063-2064 it is even getting the provider volume id, but that code is setting the volume id only in the Volume, and not setting the VirtualMachine.providerVolumeIds. Why not?
And actually, if there is going to be a VirtualMachine.volumes field, why even bother with a VirtualMachine.providerVolumeIds field? One could as easily get the provider volume ids out of VirtualMachine.volumes.
So my suggestion is to drop VirtualMachine.providerVolumeIds, along with its getter and setter - they are not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant