Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tcl package version shows as 1.2.3 in 1.3.8 download #170

Open
apnadkarni opened this issue Oct 16, 2021 · 3 comments
Open

Tcl package version shows as 1.2.3 in 1.3.8 download #170

apnadkarni opened this issue Oct 16, 2021 · 3 comments

Comments

@apnadkarni
Copy link

Describe the bug
Doing a package require loon after downloading the 1.3.8 loon release from github returns 1.2.3 as the package version, not 1.3.8. Is this expected behavior?

To Reproduce
See above.

Expected behavior
Expected to see 1.3.8 as the package version.

Screenshots
N/A

Desktop (please complete the following information):

  • Windows 10, Tcl 8.6.11
@z267xu
Copy link
Contributor

z267xu commented Oct 16, 2021

I do not encounter such issue. Would you please show more details (e.g. your code)?

> devtools::install_github("great-northern-diver/loon", subdir = "R")
> packageVersion("loon")
[1] ‘1.3.8’

@apnadkarni
Copy link
Author

apnadkarni commented Oct 16, 2021

Thanks for the quick response. All I did was a package require loon in Tcl.

(src) 1 % package require loon
1.2.3

The top of the pkgIndex.tcl file contains these lines:

package ifneeded loon 1.2.3 "
   package provide loon 1.2.3 

Is it possible the Tcl package versions and the R package versions are different by design?

See

package provide loon 1.2.3

@z267xu
Copy link
Contributor

z267xu commented Oct 17, 2021

I see. After loon 1.2.3, most changes are made in R so that the "version" in tcltk is not up to date. Thanks for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants