Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tk fmt is inconsistent in printing final newline #942

Open
nogweii opened this issue Oct 31, 2023 · 0 comments
Open

tk fmt is inconsistent in printing final newline #942

nogweii opened this issue Oct 31, 2023 · 0 comments
Labels
component/cli Command Line Interface good first issue Good for newcomers kind/bug Something isn't working priority/low

Comments

@nogweii
Copy link

nogweii commented Oct 31, 2023

Depending on whether there were any files that had the formatting fixed, a newline won't be printed. If all files checked are already correctly formatted, a trailing newline is printed.

Pretty minor, but figured the inconsistency wasn't intentional. 😄

Example script to demonstrate and outputs:

test.sh

tk fmt example.jsonnet
echo "--------"

When ran with incorrect formatting

Formatted 1 files--------

When the files don't need correction

All discovered files are already formatted. No changes were made
--------

@zerok zerok added kind/bug Something isn't working good first issue Good for newcomers component/cli Command Line Interface priority/low labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cli Command Line Interface good first issue Good for newcomers kind/bug Something isn't working priority/low
Projects
Status: Backlog
Development

No branches or pull requests

2 participants