Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifests not sorted by .metadata.generateName #931

Closed
ilian opened this issue Sep 28, 2023 · 1 comment · Fixed by #1031
Closed

Manifests not sorted by .metadata.generateName #931

ilian opened this issue Sep 28, 2023 · 1 comment · Fixed by #1031
Assignees
@zerok

Comments

@ilian
Copy link

ilian commented Sep 28, 2023 •
edited

Output of tanka show is non-deterministic when multiple manifests are defined when .metadata.generateName is defined without .metadata.name.
It could be worthwhile to take the value of .metadata.generateName into consideration when sorting.

There could be multiple manifests defined with the same .metadata.generateName for which the sort order can be non-deterministic. When manifests have different values for this field, then it would be nice to have them sorted.
@zerok zerok mentioned this issue May 22, 2024
Merged
@zerok zerok self-assigned this May 22, 2024
@zerok
Copy link
Contributor

zerok commented May 22, 2024

Hi 🙂 I've prepared a PR that should solve this. Can you please give it a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zerok zerok

Labels
None yet
Projects
Tanka
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use generateName as last comparison when sorting grafana/tanka
2 participants
@zerok @ilian