-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport section in module README.md files is incorrect for most modules #10118
Comments
This https://github.com/googleapis/google-cloud-java/tree/main/java-dialogflow This comes from template: https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/java_library/README.md
Our procedure omits the transport option, resulting in the default value "grpc" https://github.com/googleapis/google-cloud-java/blob/main/generation/new_client/README.md. @meltsufin In your observation, how did you check REST is enabled for an API? |
The source of truth is in |
Interesting. I thought that BUILD.bazel files are generated from the service yaml file. https://github.com/googleapis/googleapis/blob/master/google/cloud/dialogflow/v2/dialogflow_v2.yaml does not have any mention in grpc, rest, or transport. |
cc: @blakeli0 |
Agreed. In addition, repo-metadata.json was generated with wrong transport and also never got updated, which might be the root cause. |
Rectifying this should be considered as part of #10090 whenever that is being worked on |
Let's work on this after the README files are created by the hermetic build process. |
In most modules it says "gRPC", even though REST is enabled.
@suztomo
The text was updated successfully, but these errors were encountered: