You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// Definitions to make unit tests pass static analysis more easily.
#pragma once
// GoogleTest's macro expansions do some things that Clang Tidy doesn't like, so we work around
// them here using NOLINT directives.
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables,cppcoreguidelines-macro-usage,cppcoreguidelines-owning-memory)
#define TIDY_TEST(test_suite_name, test_name) TEST(test_suite_name, test_name)
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables,cppcoreguidelines-macro-usage,cppcoreguidelines-owning-memory)
#define TIDY_TEST_F(test_fixture, test_name) TEST_F(test_fixture, test_name)
// NOLINTNEXTLINE(cppcoreguidelines-macro-usage,cppcoreguidelines-avoid-goto)
#define TIDY_EXPECT_NO_THROW(statement) EXPECT_NO_THROW(statement)
All that would have to be added is a NOLINT comment at the end of the WillOnce function. Line 1010. Tried building with that NOLINT and the warning dissapears.
Is the feature specific to an operating system, compiler, or build system version?
Not entirely sure. For some reason, building on Windows I don't run into issues, but I do on Linux. I'm using the LLVM tools at 18.1.4. Specific to clang-tidy. The main differences I could potentially see is just that I'm using Unix Makefiles for the build on Linux instead of Ninja and that maybe the LLVM tools are different just cause of platform? They're both tagged at the same version.
The text was updated successfully, but these errors were encountered:
Does the feature exist in the most recent commit?
No
Why do we need this feature?
I can't find a way to quiet this warning nicely:
From this code:
clang_tidy_helpers.h:
mock_lm75_i2c_master.h:
read_temp_test.cpp:
Describe the proposal.
All that would have to be added is a NOLINT comment at the end of the WillOnce function. Line 1010. Tried building with that NOLINT and the warning dissapears.
Is the feature specific to an operating system, compiler, or build system version?
Not entirely sure. For some reason, building on Windows I don't run into issues, but I do on Linux. I'm using the LLVM tools at 18.1.4. Specific to clang-tidy. The main differences I could potentially see is just that I'm using Unix Makefiles for the build on Linux instead of Ninja and that maybe the LLVM tools are different just cause of platform? They're both tagged at the same version.
The text was updated successfully, but these errors were encountered: