Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor - Move Search Logic from Search.execute() to FhirEngine.search() #2540

Open
itstanany opened this issue May 12, 2024 · 0 comments · May be fixed by #2541
Open

refactor - Move Search Logic from Search.execute() to FhirEngine.search() #2540

itstanany opened this issue May 12, 2024 · 0 comments · May be fixed by #2541
Labels
P2 Medium priority issue type:code health

Comments

@itstanany
Copy link

Describe the Issue

  • For Improving separation of concerns and single responsibility, I see search logic should be moved from Saerch.execute extension function to the fhir engine search method

Would you like to work on the issue?
Y
itstanany added a commit to itstanany/android-fhir that referenced this issue May 12, 2024
@itstanany
ref/google#2540-Move Search Logic from Search.execute() to FhirEngine…
5849301 
….search()
@itstanany itstanany linked a pull request May 12, 2024 that will close this issue
Open
7 tasks
itstanany added a commit to itstanany/android-fhir that referenced this issue May 12, 2024
@itstanany
Merge branch 'master' into itstanany/google#2540-Move-Search-Logic-fr…
601ebe1 
…om-Search.execute()-to-FhirEngine.search()
@santosh-pingle santosh-pingle added P2 Medium priority issue type:code health labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Medium priority issue type:code health
Projects
Android FHIR SDK
Status: New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref/#2540-Move Search Logic from Search.execute() to FhirEngine.search() itstanany/android-fhir
2 participants
@itstanany @santosh-pingle