Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GitHub Codespaces #2481

Open
vorburger opened this issue Mar 15, 2024 · 0 comments
Open

Support GitHub Codespaces #2481

vorburger opened this issue Mar 15, 2024 · 0 comments
Assignees
@vorburger
Labels
P2 Medium priority issue type:enhancement New feature or request

Comments

@vorburger
Copy link
Member

Is your feature request related to a problem? Please describe.
In order to be able to test e.g. #2463 for #2237, as well as to be able to work on #2232, it would be much easier, at least for me, if I didn't need to have a computer with the Android Studio with the Android SDK etc. set up. (I originally used to have it set up, but changed computers since.)

Describe the solution you'd like
A great solution for this are GitHub's Codespaces, based on Dev Containers.

Describe alternatives you've considered
There are none.

Would you like to work on the issue?
Yes, I'll explore how hard it would be to make at least a very basic initial version available.
@vorburger vorburger self-assigned this Mar 15, 2024
@vorburger vorburger mentioned this issue Mar 15, 2024
Open
vorburger added a commit to vorburger/vorburger-dotfiles-bin-etc that referenced this issue Mar 15, 2024
@vorburger
fix: Do not set ANDROID_HOME when running on GitHub Codespaces
7fa4de9 
Required (for me) for google/android-fhir#2481,

because https://github.com/NordcomInc/devcontainer-features installs the Android SDK into /usr/local/lib/android, not ~/Android.
vorburger added a commit that referenced this issue Mar 15, 2024
@vorburger
Initial GitHub Codespaces (AKA Dev Container) configuration (see #2481)
cfa8ee1
@vorburger vorburger mentioned this issue Mar 15, 2024
Merged
vorburger added a commit that referenced this issue Mar 15, 2024
@vorburger
Initial GitHub Codespaces (AKA Dev Container) configuration (see #2481)
7d7007d
vorburger added a commit that referenced this issue Mar 15, 2024
@vorburger
Initial GitHub Codespaces (AKA Dev Container) configuration (see #2481)
4d8c8dc
This was referenced Mar 15, 2024
Closed
Open
@MJ1998 MJ1998 added type:enhancement New feature or request P2 Medium priority issue labels Mar 18, 2024
vorburger added a commit that referenced this issue Apr 17, 2024
@vorburger
Initial GitHub Codespaces (AKA Dev Container) configuration (see #2481)
b355639
vorburger added a commit that referenced this issue Apr 17, 2024
@vorburger
Initial GitHub Codespaces (AKA Dev Container) configuration (see #2481)…
6ff0643 
… (#2482)

Intentionally does not install Gradle VSC extension after all (because it doesn't seem to work well).

Installs Java 17 instead of 11 in GitHub Codespace Dev Container so that the Gradle build works on CLI in Codespaces.

Uses akhildevelops instead of nordcominc to install Android SDK because that seems to work better.

Note that you'll need the akhildevelops/devcontainer-features#7 workaround.

Includes initial documentation describing Dev Containers for GitHub Codespaces support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vorburger vorburger

Labels
P2 Medium priority issue type:enhancement New feature or request
Projects
Android FHIR SDK
Status: New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vorburger @MJ1998