-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate HTTP Content-Type
header
#1930
Comments
@silverwind thanks for this report! You're certainly correct, from my own testing:
I can't actually see where the |
Okay, so this issue is worse than originally described!
Us setting We can two one of two things:
We should probably do an audit of all of our routes for content type to fully fix this issue. @nrwiersma any thoughts on how to best tackle this? |
Describe the bug
It seems Athen's HTTP server delivers duplicate HTTP
Content-Type
headers. It's not breaking anything as far as I can tell but my reverse proxy log is full of warnings regarding it.To Reproduce
Run above curl against athens
Expected behavior
A single
Content-Type
header.Environment (please complete the following information):
gomods/athens
go1.20.12 linux/amd64
v0.13.1
fs
Additional context
Potentialyl relevant config option:
ATHENS_GO_BINARY_ENV_VARS=GOPROXY=proxy.golang.org,direct
Header seems to be coming from here:
athens/pkg/middleware/content_type.go
Line 11 in b72f01b
The text was updated successfully, but these errors were encountered: