Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: on PPC64, FCMPO Fx, Fy, CRz assembles incorrectly #67359

Closed
pmur opened this issue May 14, 2024 · 1 comment
Closed

cmd/asm: on PPC64, FCMPO Fx, Fy, CRz assembles incorrectly #67359

pmur opened this issue May 14, 2024 · 1 comment
Assignees
@pmur
Labels
arch-ppc64x compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.23

Comments

@pmur
Copy link
Contributor

pmur commented May 14, 2024

Go version

go1.23-a1247673ca

Output of go env in your module/workspace:

GOARCH='amd64'
GOHOSTOS='linux'

What did you do?

I added an asm test case for FCMPO F1, F2, CR0 // fc011040 which should assemble identically to FCMPO F1, F2 // fc011040 in cmd/asm/internal/asm/testdata/ppc64.s

What did you see happen?

The test produced the following error endtoend_test.go:239: 03016 (testdata/ppc64.s:766) FCMPO F1, F2, CR0: have encoding fd010040, want fc011040

What did you expect to see?

The instruction should assemble identically to its equivalent 2 argument form.
@pmur pmur self-assigned this May 14, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 14, 2024
@gopherbot
Copy link

Change https://go.dev/cl/585640 mentions this issue: cmd/asm: on PPC64, fix assembling of FCMPO opcode

@dmitshur dmitshur added this to the Go1.23 milestone May 17, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmur pmur

Labels
arch-ppc64x compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Compiler / Runtime
Status: Done
Milestone
Go1.23
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @pmur