Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/netip: failed TestInlining #67354

Closed
abner-chenc opened this issue May 14, 2024 · 2 comments
Closed

net/netip: failed TestInlining #67354

abner-chenc opened this issue May 14, 2024 · 2 comments
Assignees
@tklauser
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.23

Comments

@abner-chenc
Copy link
Contributor

abner-chenc commented May 14, 2024 •
edited by mengzhuo

Go version

go version devel go1.23-8623c0ba95 Mon May 13 21:47:29 2024 +0000 linux/loong64

Output of go env in your module/workspace:

GO111MODULE=''
GOARCH='loong64'
GOBIN=''
GOCACHE='/tmp/abner-gocache'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='loong64'
GOHOSTOS='linux'
GONOSUMDB=''
GOOS='linux'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOSUMDB='sum.golang.org'
GOTMPDIR='/tmp/abner-gotmp'
GOTOOLCHAIN='auto'
GOVERSION='devel go1.23-8623c0ba95 Mon May 13 21:47:29 2024 +0000'
GODEBUG=''
GCCGO='gccgo'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -mabi=lp64d -pthread -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/abner-gotmp/go-build716523635=/tmp/go-build -gno-record-gcc-switches'

What did you do?

cd src && ./all.bash

What did you see happen?

ok  	net/http/pprof	5.054s
ok  	net/internal/cgotest	0.002s
ok  	net/internal/socktest	0.002s
ok  	net/mail	0.005s
--- FAIL: TestInlining (0.61s)
    inlining_test.go:91: "Addr.AsSlice" is no longer inlinable
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*node[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]).entry"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*indirect[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]).empty"
    inlining_test.go:100: not in expected set, but also inlinable: "abi.Escape[go.shape.*uint8]"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[go.shape.struct"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*node[go.shape.*internal/abi.Type,go.shape.interface"
    inlining_test.go:100: not in expected set, but also inlinable: "cmp.Compare[go.shape.int]"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*HashTrieMap[go.shape.struct"
    inlining_test.go:100: not in expected set, but also inlinable: "IPv6LinkLocalAllRouters"
    inlining_test.go:100: not in expected set, but also inlinable: "Addr.Next"
    inlining_test.go:100: not in expected set, but also inlinable: "Addr.string4In6"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*entry[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]).lookup"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[internal/concurrent.entry[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]]).CompareAndSwap"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[internal/concurrent.entry[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]]).Swap"
    inlining_test.go:100: not in expected set, but also inlinable: "weak.Pointer[net/netip.addrDetail].Strong"
    inlining_test.go:100: not in expected set, but also inlinable: "weak.Pointer[go.shape.struct"
    inlining_test.go:100: not in expected set, but also inlinable: "Addr.MarshalBinary"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*HashTrieMap[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]).iter"
    inlining_test.go:100: not in expected set, but also inlinable: "unique.clone[go.shape.struct"
    inlining_test.go:100: not in expected set, but also inlinable: "Addr.isZero"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.newIndirectNode[go.shape.*internal/abi.Type,go.shape.interface"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*entry[*internal/abi.Type,interface"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*HashTrieMap[*internal/abi.Type,interface"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*HashTrieMap[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]).CompareAndDelete"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[internal/concurrent.entry[go.shape.*internal/abi.Type,go.shape.interface"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[internal/concurrent.entry[*internal/abi.Type,interface"
    inlining_test.go:100: not in expected set, but also inlinable: "cmp.isNaN[go.shape.uint16]"
    inlining_test.go:100: not in expected set, but also inlinable: "mask6"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*HashTrieMap[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]).Enumerate"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*entry[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]).compareAndDelete"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[internal/concurrent.entry[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]]).Store"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*node[*internal/abi.Type,interface"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.newIndirectNode[go.shape.struct"
    inlining_test.go:100: not in expected set, but also inlinable: "unique.Handle[go.shape.struct"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[internal/concurrent.node[*internal/abi.Type,interface"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.newEntryNode[go.shape.struct"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*node[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]).indirect"
    inlining_test.go:100: not in expected set, but also inlinable: "IPv6Loopback"
    inlining_test.go:100: not in expected set, but also inlinable: "Addr.string4"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[internal/concurrent.node[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]]).Swap"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*indirect[go.shape.*internal/abi.Type,go.shape.interface"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*HashTrieMap[go.shape.*internal/abi.Type,go.shape.interface"
    inlining_test.go:100: not in expected set, but also inlinable: "cmp.Compare[uint16]"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*HashTrieMap[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]).Load"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[internal/concurrent.node[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]]).Load"
    inlining_test.go:100: not in expected set, but also inlinable: "Addr.string6"
    inlining_test.go:100: not in expected set, but also inlinable: "appendHexPad"
    inlining_test.go:100: not in expected set, but also inlinable: "cmp.isNaN[go.shape.int]"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*HashTrieMap[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]).LoadOrStore"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[internal/concurrent.node[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]]).Store"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.newEntryNode[go.shape.*internal/abi.Type,go.shape.interface"
    inlining_test.go:100: not in expected set, but also inlinable: "Prefix.isZero"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*indirect[go.shape.struct"
    inlining_test.go:100: not in expected set, but also inlinable: "cmp.Compare[go.shape.uint16]"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*node[go.shape.struct"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*HashTrieMap[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]).expand"
    inlining_test.go:100: not in expected set, but also inlinable: "concurrent.(*indirect[*internal/abi.Type,interface"
    inlining_test.go:100: not in expected set, but also inlinable: "IPv4Unspecified"
    inlining_test.go:100: not in expected set, but also inlinable: "Addr.Prev"
    inlining_test.go:100: not in expected set, but also inlinable: "cmp.Compare[int]"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[internal/concurrent.node[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]]).CompareAndSwap"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[internal/concurrent.entry[net/netip.addrDetail,internal/weak.Pointer[net/netip.addrDetail]]]).Load"
    inlining_test.go:100: not in expected set, but also inlinable: "unique.Handle[net/netip.addrDetail].Value"
    inlining_test.go:100: not in expected set, but also inlinable: "atomic.(*Pointer[internal/concurrent.entry[go.shape.struct"
    inlining_test.go:100: not in expected set, but also inlinable: "unique.Make[net/netip.addrDetail]"
FAIL
FAIL	net/netip	0.628s
ok  	net/rpc	0.026s
ok  	net/rpc/jsonrpc	0.007s
FAIL
go tool dist: Failed: exit status 1

What did you expect to see?

all test pass
@mauri870
Copy link
Member

Should be fixed in CL 585058

@seankhliao seankhliao changed the title net/netip:FAIL: TestInlining net/netip: failed TestInlining May 14, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/585058 mentions this issue: net/netip: fix TestInlining after CL 585057

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label May 14, 2024
@dmitshur dmitshur added this to the Go1.23 milestone May 14, 2024
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label May 14, 2024
@tklauser tklauser self-assigned this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tklauser tklauser

Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.23
Development

No branches or pull requests
5 participants
@tklauser @dmitshur @gopherbot @mauri870 @abner-chenc