Replies: 10 comments 35 replies
-
|
ping @gokadzev |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
@offa is there any problem there? https://gitlab.com/fdroid/fdroiddata/-/merge_requests/12765 |
Beta Was this translation helpful? Give feedback.
-
|
Not a real problem, I'm just not familiar with flutter builds :-) It seems to install dependencies correctly but finally fails with This step seems to fail. Do you have an idea? |
Beta Was this translation helpful? Give feedback.
-
if it rebuilds the app from source as a release, the problem can be release key/keystore/signing, which of course isn't public. maybe it gets keystore from somewhere else? i have no idea |
Beta Was this translation helpful? Give feedback.
-
|
also versionCode is wrong in the submission, it should be 48 instead of 483 |
Beta Was this translation helpful? Give feedback.
-
Yes, builds are from source. F-Droid build should do signing automatically (… as far as I know).
Fixed, thanks. |
Beta Was this translation helpful? Give feedback.
-
|
Build is working now. There's one think left: Is there a way to remove or disable the update (eg. a fdroid build flavour?) |
Beta Was this translation helpful? Give feedback.
-
|
I'm trying to find any information about it but currently i have nothing. i hope i will be able to remove it only for fdroid builds |
Beta Was this translation helpful? Give feedback.
-
|
@offa solved: updater file (which is empty/disabled by default): https://github.com/gokadzev/Musify/blob/master/lib/services/update_manager.dart |
Beta Was this translation helpful? Give feedback.
-
|
I'm not a flutter dev, but browsing through other flutter based recipes I found some ways which could help you:
(Both projects are just examples) So you can keep the updater but disable it for fdroid. |
Beta Was this translation helpful? Give feedback.
-
the first one is for native modules, i know the second one but i didn't want to use package_info_plus. with my way updater is still available but not by default (you need to run bash file and then build), when fdroid will build it from source it's not available but when i run bash file and then build, it becomes available. (maybe i didn't explain very well but to say briefly updater is removed for fdroid builds only) Edit: i was wrong, it's possible without package_info_plus. ref: https://github.com/ImranR98/Obtainium/pull/236/files |
Beta Was this translation helpful? Give feedback.
-
|
any progress about this? |
Beta Was this translation helpful? Give feedback.
-
|
The build is green and PR waits for review. |
Beta Was this translation helpful? Give feedback.
-
|
@offa Hello, is it okay for you if i change current "no updates" implementation to the similar one(https://github.com/ImranR98/Obtainium/pull/236/files)? it looks more convenient and logical implementation for me. mainly i'm asking you because for fdroid it gives us different command than current one is (flutter build --flavor fdroid -t lib/main_fdroid.dart), so i guess pr will need changes |
Beta Was this translation helpful? Give feedback.
-
|
No problem, let me know once I can update the PR. 👍 |
Beta Was this translation helpful? Give feedback.
-
Done, it works. |
Beta Was this translation helpful? Give feedback.
-
|
Build updated, but Is this line correct btw? I have dropped the |
Beta Was this translation helpful? Give feedback.
-
I'm not sure about dropping --release flag. About the tag problem i will release 5.1.0 |
Beta Was this translation helpful? Give feedback.
-
|
Ok, then I'm going to add it again and we'll see :-) |
Beta Was this translation helpful? Give feedback.
-
|
Strange... several hours opened PRs of new apps are accepted/merged but our is delayed |
Beta Was this translation helpful? Give feedback.
-
|
There's quite a backlog for reviewers, I hope they can have a look soon. |
Beta Was this translation helpful? Give feedback.
-
|
Update: I'm working on the reproducible build at the moment, with some signature issues though (context). |
Beta Was this translation helpful? Give feedback.
-
|
@gokadzev is it possible to get a signed fdroid flavour build for the current release so I can add the signature for a reproducible build? |
Beta Was this translation helpful? Give feedback.
-
Done, check: https://github.com/gokadzev/Musify/releases/tag/5.1.0 |
Beta Was this translation helpful? Give feedback.
-
|
@offa i checked our PR, as i understand we need to remove specific flutter version and use the latest version right? if that's so i will remove it from pubspec and you will change srclibs: - flutter@3.7.11 to srclibs: - flutter@stable |
Beta Was this translation helpful? Give feedback.
-
|
You mean this discussion? I guess the hard coded flutter version is the problem as it needs manual updated once it changes. I've chosen a somewhat up to date version to get it still needs manual update from time to time. So either adding flutter as a Git submodule (example) or getting the version from the project automatically would be good. But pubspec is a good idea, it contains the info already – maybe we can use it somehow. |
Beta Was this translation helpful? Give feedback.
-
Update:Solved, there's a good solution using the pubspec file – without changes on your side! 👍 |
Beta Was this translation helpful? Give feedback.
-
Perfect 🎉 |
Beta Was this translation helpful? Give feedback.
-
|
I have opened a PR to prevent different flutter versions between GH and F-Droid (#231). This isn't necessary for the current release or RFP, but for future versions. |
Beta Was this translation helpful? Give feedback.
-
Thanks, merged. |
Beta Was this translation helpful? Give feedback.
-
|
@offa New version with changes is released (as well as fdroid version). |
Beta Was this translation helpful? Give feedback.
-
|
Thanks, I have updated the F-Droid PR. Hopefully it's merged soon. |
Beta Was this translation helpful? Give feedback.
-
|
Update: PR has been merged and should appear on F-Droid within the next days – including a reproducible build 🎉. |
Beta Was this translation helpful? Give feedback.
-
Thanks a lot! 🎉 I appreciate your help |
Beta Was this translation helpful? Give feedback.
-
|
No ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/4331465982#L1116 |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, I forgot. It's added now. |
Beta Was this translation helpful? Give feedback.
-
|
@offa Hello, do we need to do anything after build failed once? because as i see new version isn't added yet |
Beta Was this translation helpful? Give feedback.
-
|
No, I've left it alone so it will be retried ;) |
Beta Was this translation helpful? Give feedback.
-
|
this faq applies to updates too: https://gitlab.com/fdroid/wiki/-/wikis/FAQ#how-long-does-it-take-for-my-app-to-show-up-on-website-and-client :D |
Beta Was this translation helpful? Give feedback.
-
Describe your suggested feature
It would be great to get this app through the official F-Droid repository.
The fastlane metadata is available already 👍.
Additional information
Other details
No response
Acknowledgements
Beta Was this translation helpful? Give feedback.
All reactions