Fixed some errors in C# examples. #8143
Open
+22
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed error in C# example
Consistency with the GDScript example
raulsntos
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Thanks for contributing to the .NET documentation! Your fixes are looking great.
It looks like the example is using tabs for indentation, but we use spaces in the documentation.
Also, while you are editing this page, could you also fix the example in the Controlling an AnimationPlayer animation section? The _Process method is still using float instead of double.
raulsntos
added
bug
topic:dotnet
area:manual
Co-authored-by: Raul Santos <raulsntos@gmail.com>
|
Sure, I’ll fix the other example tomorrow. |
raulsntos
requested changes
Oct 6, 2023
Comment on lines
+95
to
+112
| private AnimatedSprite2D _animatedSprite; | ||
| public override void _Ready() | ||
| { | ||
| _animatedSprite = GetNode<AnimatedSprite2D>("AnimatedSprite2D"); | ||
| } | ||
| public override void _Process(double _delta) | ||
| { | ||
| if (Input.IsActionPressed("ui_right")) | ||
| { | ||
| _animatedSprite.Play("run"); | ||
| } | ||
| else | ||
| { | ||
| _animatedSprite.Stop(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Use spaces for indentation.
Suggested change
| private AnimatedSprite2D _animatedSprite; | |
| public override void _Ready() | |
| { | |
| _animatedSprite = GetNode<AnimatedSprite2D>("AnimatedSprite2D"); | |
| } | |
| public override void _Process(double _delta) | |
| { | |
| if (Input.IsActionPressed("ui_right")) | |
| { | |
| _animatedSprite.Play("run"); | |
| } | |
| else | |
| { | |
| _animatedSprite.Stop(); | |
| } | |
| } | |
| private AnimatedSprite2D _animatedSprite; | |
| public override void _Ready() | |
| { | |
| _animatedSprite = GetNode<AnimatedSprite2D>("AnimatedSprite2D"); | |
| } | |
| public override void _Process(double delta) | |
| { | |
| if (Input.IsActionPressed("ui_right")) | |
| { | |
| _animatedSprite.Play("run"); | |
| } | |
| else | |
| { | |
| _animatedSprite.Stop(); | |
| } | |
| } |
| @@ -240,7 +240,7 @@ released. | |||
| _animationPlayer = GetNode<AnimationPlayer>("AnimationPlayer"); | |||
| } | |||
|
|
|||
| public override void _Process(float _delta) | |||
| public override void _Process(double _delta) | |||
There was a problem hiding this comment.
The delta parameter name should match the base declaration, even if unused. Sorry that I didn't mention this before, I missed it.
Suggested change
| public override void _Process(double _delta) | |
| public override void _Process(double delta) |
| @@ -70,7 +70,7 @@ Add these two and it's possible to guess almost exactly when sound or music will | |||
| GetNode<AudioStreamPlayer>("Player").Play(); | |||
| } | |||
|
|
|||
| public override void _Process(float _delta) | |||
| public override void _Process(double _delta) | |||
There was a problem hiding this comment.
Suggested change
| public override void _Process(double _delta) | |
| public override void _Process(double delta) |
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.