Add Secrets dialog retains information when cancelled

[jamcoupe]

Description

When adding a secret to an action, if you open the dialog and enter details. If you accidentally close by clicking the background or actively click "Cancel" once you click "Add Secret". The previously entered details are still present.

Gitea Version

1.21.11

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Mac OS

How are you running Gitea?

command-line

Database

PostgreSQL

[silverwind]

Could be seen as working as intented. If you close a unsaved modal accidentially, it's good to have the data back. Any saved data should of course be cleared and I think that is already the case.

[jamcoupe]

Not sure I agree with you on a secrets dialog because the information is sensitive.

I think the solution would be to have an "are you sure" dialog when clicking the backdrop and when clicking cancel it will clear the data and close the dialog.