Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review comment line number problem. #30844

Open
lunny opened this issue May 3, 2024 · 4 comments
Open

Code review comment line number problem. #30844

lunny opened this issue May 3, 2024 · 4 comments
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP type/bug

Comments

@lunny
Copy link
Member

lunny commented May 3, 2024

When comment on a previous commit of a pull request, the comment is in line number 39

image

But after two new commits pushed, the comment haven't been marked as outdated or hidden. The line number is still line 39 but now it should be line 58.

image
@lunny lunny added type/bug issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels May 3, 2024
@yp05327
Copy link
Contributor

yp05327 commented May 7, 2024

Can you provide the URL of these screenshots.

@lunny
Copy link
Member Author

lunny commented May 7, 2024

https://gitea.com/gitea/blog/pulls/367/files

@metiftikci
Copy link
Contributor

related to #21113 ?

@lunny
Copy link
Member Author

lunny commented May 24, 2024

Maybe different because there is no force push on https://gitea.com/gitea/blog/pulls/367/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lunny @yp05327 @metiftikci