Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names of subgenera don't get parsed if subgen. is included in the scientific name value #232

Open
KatjaSchulz opened this issue Jul 7, 2022 · 8 comments

Comments

@KatjaSchulz
Copy link

Psammophanes subgen. Psammophrynopsis Koch, 1953 parses fine, with a warning.

subgen. Psammophrynopsis Koch, 1953 doesn't get parsed at all.

It would be good if names preceded by subgen. would get parsed. They do occur in the wild, e.g. in current Catalogue of Life files.

@dimus
Copy link
Member

dimus commented Aug 17, 2022

hm, interesting, @gdower, do you know how often such names happen?

@gdower
Copy link
Contributor

gdower commented Aug 17, 2022

It's not super-common in the datasets that I work with, but I do see it occasionally. In World Plants/World Ferns, 0.83% of the lines include "subgen." Often in that source it's included like this: subgen. Filago (without the genus included).

@KatjaSchulz
Copy link
Author

Sorry, I should have provided more context. There are 38 subgenera with this scientificName structure in the current version of COL (2022-07-12).

colSubgen.txt

These are derived from two different sources, both entomological:
World catalogue of the tribe Sepidiini (Tenebrionidae, Coleoptera) and Lygaeoidea Species File

@dimus
Copy link
Member

dimus commented Aug 19, 2022

@KatjaSchulz and @gdower, thank you for the information! I am on a fence about this particular parsing. If there are only so few of them, does it make sense to slow down parsing for the vast majority of other names by checking this specific case?

I'll try to figure out a faster approach to check the first word.

@KatjaSchulz
Copy link
Author

I'm not really in a position to evaluate whether it would be worth it. For the time being, we can handle these through post-processing. We can revisit if we encounter more cases with this usage.

@gdower
Copy link
Contributor

gdower commented Aug 19, 2022

@yroskov and I are aiming to fix those names in the Sept release of CoL.

@dimus
Copy link
Member

dimus commented Apr 15, 2024

@gdower @yroskov, is it fixed in CoL, can this issue be closed?

@dimus
Copy link
Member

dimus commented May 2, 2024

According to @yroskov and @gdower such names are allowed by botanical code, so I am going to figure out how to parse them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants