Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"short" date skeleton parses single-digit years #928

Open
craigkovatch opened this issue Jan 20, 2022 · 1 comment
Open

"short" date skeleton parses single-digit years #928

craigkovatch opened this issue Jan 20, 2022 · 1 comment

Comments

@craigkovatch
Copy link

craigkovatch commented Jan 20, 2022

Our code is exercising this commit right now and it feels very, very strange that with the "short" date skeleton, we get these results:

  • "12/24/3" parses ⁉️
  • "12/24/33" parses
  • "12/24/333" does not parse
  • "12/24/3333" does not parse

I understand this change for days and months. And I'm sure there are obscure use cases (archaeologists?) for whom parsing a single-digit year makes sense. But my guess is the vast majority of cases where globalize parsing is being used for e.g. form input validation, this is unwanted and frankly confusing behavior.

I'm not sure I read this thread correctly -- is there a way to disable the behavior where single-digit years now parse? Seems like this should be opt-in behavior for years, or at the very least an option to opt-out.

@craigkovatch
Copy link
Author

Hi, this issue has sat without comment for 14 months now. Is there something more I should do in order to get it some attention?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant