-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser links to multiple wrong external identifiers for taxon "Candidatus Endoriftia persephone" #968
Comments
@kbseah thanks for sharing your observations re: Candidatus names.
Yes, perhaps! I'd have to look into the taxon alignment code and make sure that the candidatus prefix is handled properly. Meanwhile, perhaps @dimus or @mdoering may have some insights on how their parsers (gn parser https://github.com/gnames/gnames and gbif name parser https://github.com/gbif/name-parser resp.) handle the Candidatus names.
Thanks for adding the wikidata item! |
There is a special property for candidate names in the parsed result: http://api.checklistbank.org/parser/name?q=Candidatus%20Endoriftia%20persephone The name in the label then is quoted entirely. |
checklistbank always uses the very latest release, 3.11.0 at this time: https://github.com/CatalogueOfLife/backend/blob/master/pom.xml#L83 |
Thanks for sharing the version of GBIF parser . Would it be an idea to include this in the result snippets? |
The version you mean? You can get that from the API which you can then use to find the corresponding parser and all other dependency versions: Takes you to: https://github.com/CatalogueOfLife/backend/blob/81e1c72/pom.xml#L83 |
I was imagining embedding the version of the parse method in the parse response. currently,
produces: {
"scientificName": "\"Candidatus Endoriftia persephone\"",
"rank": "species",
"genus": "Endoriftia",
"specificEpithet": "persephone",
"candidatus": true,
"code": "bacterial",
"type": "scientific",
"label": "\"Candidatus Endoriftia persephone\"",
"labelHtml": "\"Candidatus Endoriftia persephone\"",
"parsed": true
} suggest to add some provenance like: {
"scientificName": "\"Candidatus Endoriftia persephone\"",
"rank": "species",
"genus": "Endoriftia",
"specificEpithet": "persephone",
"candidatus": true,
"code": "bacterial",
"type": "scientific",
"label": "\"Candidatus Endoriftia persephone\"",
"labelHtml": "\"Candidatus Endoriftia persephone\"",
"parsed": true,
"generatedBy": "https://github.com/CatalogueOfLife/backend/commit/81e1c72"
} |
@kbseah Apologies for the delay in dealing with the Candidatus issue. Hoping to get to it sooner rather than later. Thanks for being patient. |
hi @jhpoelen , there's no need to apologise! Thanks for your continued work in maintaining this resource for everybody. |
While familiarizing myself with the query browser, I found an unusual error when the taxon
Candidatus Endoriftia persephone
is used in a query (adding a screenshot in case this the problem is specific to my browser):https://www.globalbioticinteractions.org/?interactionType=interactsWith&targetTaxon=Candidatus%20Endoriftia%20persephone
Under the taxon name, instead of a single link per external database as expected, there are multiple links. What they all have in common is that the names start with
Candidatus
. This is a designation used only in prokaryotic nomenclature for provisional names of taxa that are not yet in culture, because the prokaryotic code requires a type culture for valid publication (details).Perhaps Candidatus names are being misinterpreted as Linnean trinomials by the name matcher?
Surprisingly there was no Wikidata item for Candidatus Endoriftia persephone, but I've just created one: https://www.wikidata.org/wiki/Q124846046
The text was updated successfully, but these errors were encountered: