Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Compiler never empties the stale tracker #3141

Open
u9g opened this issue May 15, 2024 · 2 comments
Open

Package Compiler never empties the stale tracker #3141

u9g opened this issue May 15, 2024 · 2 comments

Comments

@u9g
Copy link

u9g commented May 15, 2024

The project compiler empties the stale tracker immediately when compiling

self.stale_modules.empty();

However, when calling package_compiler.rs's compile() via the LSP, we don't empty the stale_tracker because we sidestep the ProjectCompiler by compiling using the LspProjectCompiler, which does not clear the stale tracker.

I think the line that we should empty the stale tracker would be right above here

// Verify that the build directory was created using the same version of

@u9g
Copy link
Author

u9g commented May 15, 2024

Here's an example patch of what I'm suggesting:
u9g@577e8e6

I might be missing something though as the comment here specifically mentions clearing the caches for LSP

// LSP engine so state could be reused if we don't reset it.

@lpil
Copy link
Member

lpil commented May 15, 2024

Ah! I'm not very fresh on this code so I'm not sure what the consequences are here. What is it that happens due to forgetting to reset this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants