Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPM] Unsafe build flags make importing the package by version string impossible #2149

Open
Kolos65 opened this issue May 14, 2024 · 0 comments

Comments

@Kolos65
Copy link

Kolos65 commented May 14, 2024

SPM forbids depending on packages by version string if they have unsafe build flags.

The only way to use a package with unsafe flags is by specifying the exact commit hash.

Im curious if the package truly needs those flags or if they can be removed / replaced with something else.

Current unsafe flags are:

  • -Wno-shorten-64-to-32: This is only to suppress warnings so its not a necessity
  • -O3: Does opting for O3 optimization level make that much of a difference?
  • -DNDEBUG: We can replace this with: cSettings: [.define("NDEBUG")
  • -fno-objc-arc: Do we really need this? What exactly requires this flag in the project? Can it be refactored to cope with objc arc?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant