Menu item is clickable for folders with subpages leading to 404

[olivierdalang]

Hi,

With dropdown enabled, when I have a folder (with no content) containing subpages, the folder is clickable in the navigation, leading to a 404.
I think the navigation should not create links when the page is not routable.

I fixed it like this in templates/partials/navigation.html.twig:

{% macro loop(page) %}
...
                <a href="{{ p.url }}">
...
{% endmacro %}

replaced by

{% macro loop(page) %}
...
                <a href="{% if p.routable %}{{ p.url }}{% else %}#{% endif %}">
...
{% endmacro %}

I think a proper fix would even remove the tag, but this needs a bit more work so that it displays correctly.

Thanks !

[axza]

this needs to be documented aswell in the quark theme or on learn.getgrav.org !
@rhukster

[bcneb]

Thankyou for this, I was looking for a fix!