Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Modal Toolbar not showing without admin.super permission #2408

Open
chraebsli opened this issue Apr 23, 2024 · 7 comments
Open

Menu Modal Toolbar not showing without admin.super permission #2408

chraebsli opened this issue Apr 23, 2024 · 7 comments

Comments

@chraebsli
Copy link

I found an issue regarding the toolbar in the menu modal in pages, which is only showing when the user has admin.super permission.

Currently, I only get this modal without the toolbar with let’s say user1:
Menu Modal without Toolbar

But with my admin user, I get this modal, with the toolbar:
Menu Modal with Toolbar

I tested this with a fresh Grav + Admin installation without any configuration.


Accounts

Here are my account configs (access only)

admin

access:
  site:
    login: true
  admin:
    login: true
    super: true

user1

access:
  admin:
    login: true
    configuration:
      pages: true
    pages: true
@Fuficek
Copy link

Fuficek commented May 27, 2024

I've recently stumbled upon this issue myself and is really annoying. I hope it'll get fixed soon. Seems simple to fix.

@chraebsli
Copy link
Author

Seems simple to fix.

You're free to open a PR with the fix;)

@rhukster
Copy link
Member

Scratch my comments, had the wrong issue up when responding!

@rhukster
Copy link
Member

What plugins do you have installed?

What account privs do you have? can you paste a copy of the user's account yaml file? (user/accounts/username.yaml).

I think you might have a plugin installed that is causing a conflict as i can't recreate this.

@Fuficek
Copy link

Fuficek commented May 27, 2024

Seems simple to fix.

You're free to open a PR with the fix;)

I'd like to but I'm not that good at PHP :(

@pamtbaau
Copy link

@rhukster,

  • Download Grav + Admin.
  • Surf to site and create a user to login.
    Access rights will be:
    access:
      admin:
        login: true
        super: true
      site:
        login: true
    
  • Edit current user:
    • Pages: 'Allow'
    • Super user: 'Unset'
      New access rights:
      access:
        admin:
          login: true
          pages: true
        site:
          login: true
      
  • Logoff
  • Sometimes needed to run $ bin/grav cache
  • Login
  • Go to pages
  • Click on menu of Typography => Menu options have disappeared

@chraebsli
Copy link
Author

Seems simple to fix.

You're free to open a PR with the fix;)

I'd like to but I'm not that good at PHP :(

Same here. If I'd found the file with the modal, I'd try, but haven't found it somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants