Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin.yaml pagemedia resize_quality - best value is 0.99 not 1 #2393

Open
kittyfishfrommars opened this issue Jan 23, 2024 · 0 comments
Open

Comments

@kittyfishfrommars
Copy link

kittyfishfrommars commented Jan 23, 2024

Description

.jpg / .jpeg images are not being resized and subsequently displayed in Admin Panel -> Page -> Page Media section,
if admin.yaml contains the (erroneous) following line:

pagemedia:
  resize_quality: 1

The correct highest possible value is 0.99.


Cause (apart from my own stupidity)

  • The documentation is unclear here.

Proposed solution

update all language strings and documentation (if any)

from
RESIZE_QUALITY_HELP: "The quality to use when resizing an image. Between 0 and 1 value."
to
RESIZE_QUALITY_HELP: "The quality to use when resizing an image. Between 0.01 and 0.99 value."


For reference:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant