Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal import references to its own github repo make forking and making PRs difficult #16

Open
nyetwurk opened this issue May 31, 2018 · 1 comment
Open

Internal import references to its own github repo make forking and making PRs difficult #16

nyetwurk opened this issue May 31, 2018 · 1 comment

Comments

@nyetwurk
Copy link

the istanbul and quorum clients reference their own git repo (getamis/eth-client) so forking and making a PR is kind of challenging, since any PR has to be reverted to point to this repo, rather than the repo where the PR is.
@jjhesk
Copy link

jjhesk commented Jan 24, 2019

agree..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjhesk @nyetwurk