Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use quorum.Dial #14

Open
sadysnaat opened this issue Feb 6, 2018 · 2 comments
Open

Can't use quorum.Dial #14

sadysnaat opened this issue Feb 6, 2018 · 2 comments

Comments

@sadysnaat
Copy link

package main

import (
	"log"
	"github.com/getamis/eth-client/quorum"
)
func main() {
	c, err := quorum.Dial("http://0.0.0.0:8545")
	if err != nil {
	    log.Fatalln(err)
	}
}

I get the following error

# github.com/getamis/eth-client/client
../../github.com/getamis/eth-client/client/client.go:49:6: cannot use client literal (type *client) as type Client in return argument:
	*client does not implement Client (wrong type for EstimateGas method)
		have EstimateGas(context.Context, ethereum.CallMsg) (uint64, error)
		want EstimateGas(context.Context, ethereum.CallMsg) (*big.Int, error)

Is there something I am doing wrong?

@Lsquared13
Copy link

It's not limited to quorum clients. I'm dealing with this now.

Looks like this geth commit was a breaking change for this.

@Lsquared13
Copy link

The problem occurs when you start mixing in newer versions of geth than the aforementioned commit. I assume it looks fine from the author's POV because the vendor folder here has older versions.

It's a one line fix on my fork of this repo

I'm only refraining from submitting a PR because I'm not sure what to do with the vendor files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants